Skip to content

Restore pre-3.3 local_snapshotter() argument order#2309

Merged
hadley merged 1 commit intomainfrom
local-snapshotter-args
Jan 8, 2026
Merged

Restore pre-3.3 local_snapshotter() argument order#2309
hadley merged 1 commit intomainfrom
local-snapshotter-args

Conversation

@hadley
Copy link
Member

@hadley hadley commented Jan 8, 2026

@claude
Copy link

claude bot commented Jan 8, 2026

Claude finished @hadley's task —— View job


Code Review Complete

Reviewing PR: Restore pre-3.3 local_snapshotter() argument order

Todo List:

  • Read repository guidelines (CLAUDE.md)
  • Examine changed files to understand modifications
  • Check for potential bugs or issues
  • Provide review feedback

Analysis

This PR changes the argument order in local_snapshotter() function:

  • Before: reporter first, then snap_dir
  • After: snap_dir first, then reporter

Changes made:

  1. R/snapshot-reporter.R:233-234: Swapped parameter order in function definition
  2. R/test-files.R:321: Updated function call to use explicit parameter name reporter = snap_base
  3. man/local_snapshotter.Rd: Updated documentation to match new parameter order
  4. NEWS.md: Added changelog entry

Review

LGTM. All existing calls use named arguments or default values, so the change is backward compatible.


@hadley hadley merged commit 9c948e1 into main Jan 8, 2026
13 of 14 checks passed
@hadley hadley deleted the local-snapshotter-args branch January 8, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant